he has produced a list of places he would like to go - I have very limited knowledge of USA geography is there any particular order you would recommend?
Texas - Houston, San Antonio, Dallas
Alabama, Florida (orlando) Miami, Philadelphia, Washington DC, New York, Detroit, Chicago, Monument Valley, Yellowstone, Grand Canyon, Las Vegas, San Fransisco, California, Los Angeles.
Get a map of the US, put a pin at each of these locations, and then it will become obvious how to connect the dots.
I will pick New York as the starting and ending point, because that is probably going to be the best deal for flights in and out. Then whether you go clockwise or counter-clockwise depends on the time of year.
counter-clockwise (my natural tendency): New York - Detroit - Chicago - Yellowstone - San Francisco - Los Angeles - Las Vegas - Grand Canyon - Monument Valley - San Antonio - Dallas - Houston - Alabama (what city?) - Orlando or Miami - Miami or Orlando (you have to go past Orlando to get to Miami, and will pass it again on your way back from Miami) - Washington, DC - Philadelphia - New York
.
trouble is he's starting in New Orleans as he is starting with a WWE event which he has a package ie hotel, tickets and so on so that's kind of set, which I know is kind of in the middle which isn't fabulous ie you have to go one way and then back for the rest of the places - but there we are.
.
No, either way it is still a loop:
counter-clockwise: New Orleans - Orlando/Miami - Washington, DC - Philadelphia - New York - Detroit - Chicago, etc... ending up back in New Orleans after Houston.
Or clockwise: New Orleans - Houston - Dallas - San Antonio - Monument Valley, etc... ending up back in New Orleans after New York - Phliadelphia -Washington DC - Orlando/Miami
But as others have said, if you go just by train you will be limited by where the train goes. Take a look also at bus service, I think the two major networks are still Greyhound and Trailways.
In either case he may have to think about arranging his travel by a hub-and-spoke system rather than direct place to place in continuous loop. That would be even more the case if you add any air flights into the mix!
ETA: too bad he doesn't drive; easiest approach might be to buy a cheap used car and then sell it when done (just saw some young German tourists do that on a car show on TV....)
.